Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow board to override SYS_TEXT_BASE and SYS_AT91_MAIN_CLOCK #3

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Allow board to override SYS_TEXT_BASE and SYS_AT91_MAIN_CLOCK #3

merged 1 commit into from
Oct 23, 2015
+4 −0

Conversation

wpd
Copy link

@wpd wpd commented Oct 14, 2015

I brought up u-boot-at91 on a custom board. In the process of doing so, I made some minor tweaks to the main code base.

@wpd
Copy link
Author

wpd commented Oct 22, 2015

Hi Josh,
I just tried pulling this patch out of my build and #undef-ing CONFIG_SYS_TEXT_BASE in my board header file. That doesn't work because the build system parses the board header file in order to pass CONFIG_SYS_TEXT_BASE to the loader. I end up getting lots of warnings of the form:

  CC      net/nfs.o
In file included from include/configs/nava5d3.h:23:0,
                 from include/config.h:6,
                 from include/common.h:18,
                 from net/nfs.c:25:
include/configs/at91-sama5_common.h:15:0: warning: "CONFIG_SYS_TEXT_BASE" redefined
 #define CONFIG_SYS_TEXT_BASE  0x26f00000
 ^
<command-line>:0:0: note: this is the location of the previous definition

So I'm back to my original position of letting at91-sama5_common.h define reasonable defaults for various configuration items and protecting those definitions with #indef BLAH/#endif.

--wpd

@JoshWu
Copy link

JoshWu commented Oct 23, 2015

Hi, Patrick

yes, you are right. redfined CONFIG_SYS_TEXT_BASE will cause build error.

So I'll merge your patch. Thanks again.

Best Regards,
Josh Wu

JoshWu added a commit that referenced this pull request Oct 23, 2015
@JoshWu
Merge pull request #3 from wpd/patches
a9a6808 
Allow board to override SYS_TEXT_BASE and SYS_AT91_MAIN_CLOCK
@JoshWu JoshWu merged commit a9a6808 into linux4sam:master Oct 23, 2015
ehristev pushed a commit that referenced this pull request Apr 5, 2021
@mszyprow @superna9999
test: add a simple test for the adc-keys button driver
289d0ea 
Add adc-keys device to the sandbox/test.dts and connect it to the channel
#3 of the sandbox_adc driver. The default values sampled by sandbox_adc
driver determines that button3 and button4 are released and button5 is
pressed.

Signed-off-by: Marek Szyprowski <[email protected]>
Reviewed-by: Simon Glass <[email protected]>
Signed-off-by: Neil Armstrong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wpd @JoshWu